-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BoundsX/BoundsY streams #1554
Add BoundsX/BoundsY streams #1554
Conversation
jordansamuels
commented
Jun 16, 2017
- Core code is thanks to @philippjfr via gitter
- Added notebook examples and animated gifs
- Fixed mismatch in Bounds.bounds doc string
* Core code is thanks to @philippjfr via gitter * Added notebook examples and animated gifs * Fixed mismatch in Bounds.bounds doc string
Thanks so much for those examples, they look great! We're not including the gifs directly in the repo at least for now. I'll upload them to assets.holoviews.org in the morning, then you can link to them from the notebook. |
@philippjfr understood. In the end, I went with a different set of examples than what we discussed. |
Very nice! |
Thank you! Those examples look great! |
I have now uploaded these to our assets bucket, you can display them in the notebooks by linking to: http://assets.holoviews.org/gifs/examples/streams/bokeh/boundsx_selection.gif Once you've removed them from this PR and updated the notebooks, this is ready to merge. That will be our first user contributed gallery example, thanks again! |
* Replace boundsx demo gif with assets link * Fix minor error in boundsy notebook * New boundsy gif, will replace with assets link on next commit
Thanks so much for adding this. I'll go ahead and merge now. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |