Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in canonicalizing xarray data #1524

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Fixed bug in canonicalizing xarray data #1524

merged 2 commits into from
Jun 7, 2017

Conversation

philippjfr
Copy link
Member

There is a bug in how xarray arrays are canonicalized which occurs when there is scalar dimension in the dataset which is not referenced in the kdims. This fixes that bug and also fixes another bug that ignores explicitly supplied kdims when constructing an Element from a xr.DataArray.

Fixes bug holoviz/geoviews#72

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: component: data labels Jun 6, 2017
@jlstevens
Copy link
Contributor

Looks good and the tests are passing. Merging.

@jlstevens jlstevens merged commit b8dae63 into master Jun 7, 2017
@philippjfr philippjfr deleted the xarray_canonical branch June 17, 2017 17:04
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: component: data type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants