Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed using xarray with dask arrays #1512

Merged
merged 3 commits into from
Jun 4, 2017
Merged

Allowed using xarray with dask arrays #1512

merged 3 commits into from
Jun 4, 2017

Conversation

philippjfr
Copy link
Member

XArray supports wrapping around dask arrays. Generally this doesn't cause any issues but the dimension_values method should always return an in-memory NumPy array so this PR is sufficient for us to have full support for dask arrays via xarray.

@jlstevens
Copy link
Contributor

Looks good!

I had a prototype line like this once before but supporting dask via xarray makes sense. My main comment is that a few unit tests would be nice (marked optional and dask would need to be available on travis).

@philippjfr
Copy link
Member Author

I'm now running all existing Dataset tests against an xarray dataset containing dask arrays. Those 60 unit tests should cover it pretty well.

@jlstevens
Copy link
Contributor

I'll merge when the tests go green.

@philippjfr
Copy link
Member Author

Hold off on merging, found some issues.

@philippjfr
Copy link
Member Author

Okay, now fixed. Ready to merge once tests pass.

@jlstevens
Copy link
Contributor

Tests have passed. Merging.

@jlstevens jlstevens merged commit a213f38 into master Jun 4, 2017
@philippjfr philippjfr deleted the xarray_dask branch June 17, 2017 17:04
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants