Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed Element to mpl ElementPlot._finalize_axis #1269

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

philippjfr
Copy link
Member

In debugging another issue I found that matplotlib plots are not correctly handling DynamicMaps of overlays as ElementPlots are not passing the currently displayed Element to the _finalize_axis method. This means that the method does an additional lookup which fails when the data comes from a DynamicMap returning Overlays.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: mpl labels Apr 11, 2017
@jlstevens
Copy link
Contributor

Is this PR ready to review/merge?

@philippjfr
Copy link
Member Author

Yes, ready.

@jlstevens
Copy link
Contributor

Looks good and the tests are passing. Merging.

@jlstevens jlstevens merged commit c6629c1 into master Apr 11, 2017
@philippjfr philippjfr deleted the mpl_finalize branch April 19, 2017 21:38
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: backend: mpl type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants