Simplified DynamicMap reindex as it is handled automatically #1267
Conversation
|
I also added made sure that any clone of a DynamicMap references the original DynamicMap in its |
philippjfr
force-pushed
the
dynamic_reindex_fix
branch
from
3fa4bf6
to
8ef0b8a
Compare
| # Ensure the clone references this object to ensure | ||
| # stream sources are inherited | ||
| if clone.callback is self.callback: | ||
| clone.callback = self.callback.clone() |
There was a problem hiding this comment.
I don't quite get this line. Why would self.callback have a clone method? Isn't that a Callable around the callback?
There was a problem hiding this comment.
Yes, see above I gave it a clone method. Can do it manually here I suppose and remove it again. Up to you.
There was a problem hiding this comment.
It is at the top of the diff and I must have just skimmed over clone without registering it. Thanks for clarifying!
|
Other than one bit I don't understand it looks fine and I'll merge once the tests pass. |
|
Needs a bunch of tests too, so not quite ready yet. |
|
Let's get this merged now since tests are failing on master holding up other PRs. I'll add tests later. |
|
Agreed. Merging now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The new Callable inspection in _execute_callback now automatically remaps key dimensions onto the callback so wrapping the callable is no longer needed.