Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied formatting to bokeh datetime hover tool labels #1263

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 10, 2017

As requested in #1261 datetimes in the hover tool should be formatted correctly. This has annoyed me myself a fair bit. Currently the only approach to make this work is to send the formatted strings as a column in the ColumnDataSource as outlined here, in future we can hopefully use JS datetime formatting to support this. I do think this is an important feature (it's visible in a number of my demos like the StockExplorer) and should make it into 1.7.

See bokeh/bokeh#1239 for status of a more convenient/efficient mechanism for this.

@jlstevens
Copy link
Contributor

Shame it is such a pain but I agree it needs to be fixed.

File an issue if you think there may be cleaner way to handle this in future. In the meantime I'll merge this PR given that the tests are passing.

@jlstevens jlstevens merged commit 9a0a2fd into master Apr 10, 2017
@philippjfr
Copy link
Member Author

File an issue if you think there may be cleaner way to handle this in future. In the meantime I'll merge this PR given that the tests are passing.

Not until bokeh do something about it.

@jbednar jbednar deleted the hover_datetimes branch April 10, 2017 18:06
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants