Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint overlay #1213

Merged
merged 4 commits into from
Mar 16, 2017
Merged

Adjoint overlay #1213

merged 4 commits into from
Mar 16, 2017

Conversation

philippjfr
Copy link
Member

Implement overlaying of AdjointLayouts as originally outlined in #987.

@philippjfr philippjfr added tag: API type: feature A major new feature labels Mar 16, 2017
@jlstevens
Copy link
Contributor

A screenshot/example would be good to illustrate the new behavior.

@philippjfr
Copy link
Member Author

Here's an example:

hv.Image(np.random.rand(10,10)).hist() * hv.Text(0,0, 'A') 

image

Works the same for HoloMaps and DynamicMaps:

hv.HoloMap({i: hv.Image(np.random.rand(10,10)) for i in range(5)}).hist() * hv.Text(0,0, 'A') 

screen shot 2017-03-16 at 4 44 40 pm

The overlaying of adjoined plots works too, however overlaid adjoined plots don't behave particularly well currently so I'll open another issue about that. For now it's mostly useful for being able to overlay the main plot.

@jbednar
Copy link
Member

jbednar commented Mar 16, 2017

Thanks!

@jlstevens
Copy link
Contributor

Looks good - happy to merge once it is ready and the tests pass.

@philippjfr
Copy link
Member Author

Travis has somehow decided not to run a PR build, or it's just being slow.

@philippjfr
Copy link
Member Author

Looks like it's not going to, but there should be no failures in this PR and since the branch is up to date with master the push and PR builds are equivalent anyway. Merge away once it passes.

@philippjfr
Copy link
Member Author

Appears to be an persisting py3 issue, so going to have to start another build anyway.

@philippjfr
Copy link
Member Author

Ready.

@jlstevens jlstevens merged commit f1edbab into master Mar 16, 2017
@philippjfr philippjfr deleted the adjoint_overlay branch April 11, 2017 12:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: API type: feature A major new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants