-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matplotlib aspect fixes #1209
Matplotlib aspect fixes #1209
Conversation
d4909c9
to
a72fb35
Compare
a72fb35
to
ac3cd3a
Compare
Good to see three issues sorted with so little code! I guess the test data will now need to be updated... |
Maybe, don't know yet, made a typo. |
I think the original reason we tried to force everything to be square is that it made layouts easier. |
Absolutely and without the layout fix that I added these examples would have really odd spacing I'm sure. |
91c200d
to
0d6a0fb
Compare
Ready to merge whenever, rebuilt the test data and PR build is passing. |
Excellent; thanks so much for fixing this previously very surprising behavior. That said, even though these are surely reasonable to consider as bug fixes, they will affect the look and feel of existing notebooks, so they should be mentioned under compatibility changes. Basically, if someone was relying on Layout to make things square, they will now have to force them to be square, and it will be helpful to mention how to do that in the release notes. |
Sorry if I missed it but that is a good point - is there any easy way to restore the old behavior if necessary? |
Not really no, except setting |
Ok, then as Jim said it will need to be mentioned in the release notes. The pr build is passing, is it ready to merge? |
Yes, ready. |
Great. Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #199, #996 and #1144. Plots in Layouts are no longer forced to square, semilog/loglog plots correctly apply aspects, and axis ranges are set after ticks.