Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed top-level util import issue #1180

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Fixed top-level util import issue #1180

merged 1 commit into from
Mar 9, 2017

Conversation

philippjfr
Copy link
Member

As pointed out in #1134 (comment) it turns out my previous fix wasn't quite sufficient, the wildcard import from hv.core.spaces was overriding hv.util with hv.core.util. Ideally we should get rid of all wildcard imports to avoid issues like this.

@PeterDSteinberg
Copy link

I agree on getting rid of wildcard imports, or limiting their usage and using them only when __all__ has been defined.

@philippjfr
Copy link
Member Author

Right, I think we can easily replace the remaining wildcard import in the top-level __init__, the only one I would leave is for the element module, which does define __all__ and would be too much of a pain to list out explicitly.

@philippjfr
Copy link
Member Author

Just checked and all other imports define __all__. Ready to merge.

@jlstevens
Copy link
Contributor

Great!

@jlstevens jlstevens merged commit f87ca46 into master Mar 9, 2017
@philippjfr philippjfr deleted the util_import branch April 19, 2017 21:39
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants