Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Layout/Grid titles in bokeh #1017

Merged
merged 5 commits into from
Dec 18, 2016
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 11, 2016

As I had suggested in #989 it is possible to add a Div as a title to a composite plot. This finally adds consistency in titles between matplotlib and bokeh backends for Layout and Grid plots.

Still needs tests.

Examples

Layout

screen shot 2016-12-11 at 10 24 55 pm

Grid

screen shot 2016-12-11 at 10 27 19 pm

@jlstevens
Copy link
Contributor

That looks good! Shame bokeh doesn't let you do this more directly.

Make sure to test this in Chrome/Firefox/Safari and if you find it is working well, I am happy to merge.

@philippjfr
Copy link
Member Author

Ready to merge when tests pass.

@@ -153,7 +154,43 @@ def sync_sources(self):



class GridPlot(BokehPlot, GenericCompositePlot):
class CompositePlot(BokehPlot):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a docstring explaining what this base class is for. Right now, everything CompositePlot does seems to be only needed by LayoutPlot. Any ideas what CompositePlot could be used for that isn't LayoutPlot?

Copy link
Member Author

@philippjfr philippjfr Dec 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GridPlot, just below, but yes I'll add a docstring.

@jlstevens
Copy link
Contributor

Looks good, thanks!

@jlstevens jlstevens merged commit d9b0d95 into master Dec 18, 2016
@philippjfr philippjfr deleted the bokeh_composite_titles branch January 7, 2017 15:00
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants