Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hover tooltips for Curve and Path types #1004

Merged
merged 2 commits into from
Dec 8, 2016
Merged

Fixed hover tooltips for Curve and Path types #1004

merged 2 commits into from
Dec 8, 2016

Conversation

philippjfr
Copy link
Member

Currently dimensions that shouldn't be are appearing in the hover tooltips. Additionally on CurvePlot the NdOverlay dimension information isn't supplied at all. I've also made various fixes to make color and alpha option work correctly in batched mode.

@philippjfr philippjfr added tag: backend: bokeh type: bug Something isn't correct or isn't working tag: component: plotting labels Dec 7, 2016
@jbednar
Copy link
Member

jbednar commented Dec 7, 2016

Looks good to me, and would be very welcome!

@philippjfr
Copy link
Member Author

There is a real bokeh notebook test failure because the previous data included wrong hover label. Will have to rebuild. I've also added various unit tests to check the correct hover information is set.

@jlstevens
Copy link
Contributor

Looks good to me too and the tests have passed. Ready to merge?

@philippjfr
Copy link
Member Author

Yep, go ahead.

@jbednar jbednar merged commit ceaa6d4 into master Dec 8, 2016
@jbednar jbednar deleted the hover_fixes branch December 8, 2016 03:48
@philippjfr philippjfr added this to the v1.7.0 milestone Dec 10, 2016
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: backend: bokeh tag: component: plotting type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants