Fix step interpolation rounding for datetime #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When interpolating datetime values in step(), the values where converted in floating types: this causes a lack of precision in the computation. Instead, we can do the computation in datetime64[ns].
|
Updated the broken tests. They look a lot more sane now :) |
|
Hmm, actually looking back at this. The conversion to integers (and then floats) was initially added to avoid errors when using datetimes. I'm quite surprised this is working without that conversion now. |
philippjfr
pushed a commit
that referenced
this pull request
Sep 20, 2019
When interpolating datetime values in step(), the values where converted in floating types: this causes a lack of precision in the computation. Instead, we can do the computation in datetime64[ns].
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interpolating datetime values in step(), the values where
converted in floating types: this causes a lack of precision in the
computation. Instead, we can do the computation in datetime64[ns].
Fixes #3878