-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect used DB #317
Incorrect used DB #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please rebase from master and add information to HISTORY?
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 8 8
Lines 538 538
=======================================
Hits 374 374
Misses 164 164
Continue to review full report at Codecov.
|
@rafaelpivato done! |
The used DB displayed is not the right when using a local DB
--db
among with--key
.Since
--db
overrides any external DB, safety should display "Using local DB" instead of "using pyup.io's DB". Users shouldn't use both parameters together but since we are displaying what was used, at least we should display the right one.