Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docstring for make_dataset method #2841

Closed
vfdev-5 opened this issue Oct 20, 2020 · 2 comments
Closed

Missing docstring for make_dataset method #2841

vfdev-5 opened this issue Oct 20, 2020 · 2 comments

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 20, 2020

📚 Documentation

Public method make_dataset does not have a docsting:

def make_dataset(
directory: str,
class_to_idx: Dict[str, int],
extensions: Optional[Tuple[str, ...]] = None,
is_valid_file: Optional[Callable[[str], bool]] = None,
) -> List[Tuple[str, int]]:
instances = []
directory = os.path.expanduser(directory)

It would be nice to add one.

cc @pmeier

@bjuncek
Copy link
Contributor

bjuncek commented Oct 20, 2020

I'm willing to pick that up if needed?

@fmassa
Copy link
Member

fmassa commented Nov 6, 2020

Fixed via #2879

@fmassa fmassa closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants