Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .tar.gz models to be loaded using load_models=all #3320

Closed
m10an opened this issue Sep 17, 2024 · 2 comments · Fixed by #3329
Closed

Allow .tar.gz models to be loaded using load_models=all #3320

m10an opened this issue Sep 17, 2024 · 2 comments · Fixed by #3329

Comments

@m10an
Copy link
Contributor

m10an commented Sep 17, 2024

🚀 The feature

Allow to load on server startup .tar.gz model archives using property load_models=all, besides .mar and .model files

Motivation, pitch

I am currently using TorchServe to serve models archived with the --archive-format=tgz flag. The model storage folder contains multiple versions of the same model, but currently, it is impossible to load all of them on server startup because it only works with .mar and .model files.

Alternatives

No response

Additional context

I already tested simple change in code, works as expected

@mreso
Copy link
Collaborator

mreso commented Sep 17, 2024

Hi @m10an thanks for reporting this issue. That change would be very valuable for our users I think. I am also not sure if no_archive models i.e. folder are currently included in load_models=all. Would you be interested to contribute a PR for this change? I would be happy to review it!

@m10an
Copy link
Contributor Author

m10an commented Sep 18, 2024

Hi @mreso, thank you for quick response. I will gladly contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants