Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch of comment and data type in secure_mode #731

Open
heyday98 opened this issue Feb 13, 2025 · 0 comments
Open

Mismatch of comment and data type in secure_mode #731

heyday98 opened this issue Feb 13, 2025 · 0 comments

Comments

@heyday98
Copy link

Hi team,

I have a question about _generate_noise function in optimizer.py. From the comment in _generate_noise function, it references p=53 (as though using float64), but I don’t see any explicit dtype set. By default, PyTorch generates float32 noise (with p=23). I run few test and found that generated noise has dtype of torch.float32. If that’s correct, we might need 6 samples (n=3) to achieve 128-bit precision. Is the code/comment correct, or am I missing something?

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant