Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Django 4.2 #308

Merged
merged 24 commits into from
Nov 4, 2023
Merged

Update to Django 4.2 #308

merged 24 commits into from
Nov 4, 2023

Conversation

fallen
Copy link
Member

@fallen fallen commented Jun 11, 2023

Let's update Django to latest LTS : 4.2

fallen added 13 commits July 28, 2023 18:48
Update Django-TinyMCE to 3.6.1 which updates TinyMCE from 5.10.1 to 5.10.7
The link was wrong in case Pytition was not installed at the root
of the webserver, which is what happens on YunoHost.

for instance if it's in http://domain.com/pytition/ instead of directly in http://domain.com/

One must use `reverse()` which takes care of adding the `script_prefix`
and not just put a hand-crafted relative uri as argument to `build_absolute_uri()`
This was because the logic was to show the first pane containing errors.
And the fields of the style pane were not declared as optional in the StyleForm.
Therefore the fields were marked as "errors" "this field is required".

Mark those fields as non-required.
The tab was shown as selected only when clicked, but since this is
the default tab it should be shown as selected by default.
This is a known unresolved issue in Bootstrap 4
See: twbs/bootstrap#23454
@fallen fallen merged commit 95df6a0 into master Nov 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant