Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show petition creation date on petition page #294

Closed
2 tasks done
fallen opened this issue Sep 28, 2022 · 13 comments · Fixed by #299
Closed
2 tasks done

Show petition creation date on petition page #294

fallen opened this issue Sep 28, 2022 · 13 comments · Fixed by #299

Comments

@fallen
Copy link
Member

fallen commented Sep 28, 2022

  • Make this optional
  • Allow to show either creation OR publication date
@rsk2
Copy link
Contributor

rsk2 commented Nov 30, 2022

Hi @fallen. I am interested in working on this issue, but first I wanted some help to understand it better. Can you please answer the following questions:

  • When you say petition page, do you mean the user dashboard?
  • How to make this optional? I am thinking the user needs to enable/disable it. Is that correct?

@fallen
Copy link
Member Author

fallen commented Dec 4, 2022

Hello @rsk2 thanks for your help on this :) It's much appreciated!

I would also:

  • add two new date fields in the Petition model, to hold creation and publication date.
  • prevent showing those if they are "0" (or NUL etc) for instance for petition created before this feature.
  • allow the owner of the petition to edit those dates, to set them manually in case they are empty (if the petition was created before this feature existed) or if for instance they published/unpublished the petition several times and want to reset the date to some precise date.

Tell me what you think, and whether this is clear or not :)

@rsk2
Copy link
Contributor

rsk2 commented Dec 6, 2022

Ok, thanks @fallen. Since this issue involves a lot of changes, is it fine if I break it into multiple pull requests with incremental changes? That will make the pull requests easier for you to review as well.

@fallen
Copy link
Member Author

fallen commented Dec 6, 2022

Yes good idea! 👍

@rsk2
Copy link
Contributor

rsk2 commented Dec 13, 2022

* allow the owner of the petition to edit those dates, to set them manually in case they are empty (if the petition was created before this feature existed) or if for instance they published/unpublished the petition several times and want to reset the date to some precise date.

Hi @fallen, on which page should I add the publication date so that it's value can be edited?

@fallen
Copy link
Member Author

fallen commented Dec 16, 2022

@rsk2 I would say on the petition edit page?
The one where you edit all the petition texts and settings. The /petition/<int>/edit one.

@rsk2
Copy link
Contributor

rsk2 commented Dec 17, 2022

@fallen, I have updated the PR

@rsk2
Copy link
Contributor

rsk2 commented Feb 9, 2023

@fallen, please review the PR

@fallen
Copy link
Member Author

fallen commented Feb 10, 2023

Wow sorry I completely forgot about this PR, I'll try to do the review ASAP!

@rsk2
Copy link
Contributor

rsk2 commented Feb 11, 2023

No problem @fallen

@rsk2
Copy link
Contributor

rsk2 commented Apr 29, 2023

Hi @fallen, can we close this issue?

@fallen fallen linked a pull request Apr 29, 2023 that will close this issue
@fallen
Copy link
Member Author

fallen commented Apr 29, 2023

Yes @rsk2 it's all good, thanks a lot :)

@fallen fallen closed this as completed Apr 29, 2023
@rsk2
Copy link
Contributor

rsk2 commented Apr 30, 2023

Thank you @fallen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants