Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone number validation to sign form #255

Closed
requiem958 opened this issue Sep 24, 2020 · 0 comments · Fixed by #292
Closed

Add phone number validation to sign form #255

requiem958 opened this issue Sep 24, 2020 · 0 comments · Fixed by #292

Comments

@requiem958
Copy link

Is your feature request related to a problem? Please describe.
I see that there is a detection of whether an email is correct but not on the phone number. Adding this detection would be coherent if phone number stays mandatory.

Describe the solution you'd like
Same interface as validation of e-mail, but for phone numbers.

Additional context
After crawling the web, it seems difficult to just verify all phone numbers for all country, so it must maybe be precised that only some format will be accepted.

Some regex i found
^(?:(?:\+|00)33[\s.-]{0,3}(?:\(0\)[\s.-]{0,3})?|0)[1-9](?:(?:[\s.-]?\d{2}){4}|\d{2}(?:[\s.-]?\d{3}){2})$
But only for french phone numbers, source

Benbb96 added a commit to Benbb96/Pytition that referenced this issue Aug 20, 2022
… validate Signature's phone + create test
Benbb96 added a commit to Benbb96/Pytition that referenced this issue Aug 20, 2022
… validate Signature's phone + create test
@fallen fallen self-assigned this Aug 22, 2022
@fallen fallen added this to the 2.6 milestone Aug 22, 2022
fallen pushed a commit that referenced this issue Aug 22, 2022
* Fix #255 - Add django-phonenumber-field library and use it to validate Signature's phone + create test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants