From ab0ea1ec4499b8b589bd3a5da7fdd08d9e00990e Mon Sep 17 00:00:00 2001
From: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Date: Fri, 11 Nov 2022 12:08:29 -0800
Subject: [PATCH] Fix crash with function redefinition (#14064)

Fixes #14027 (issue was surfaced by #13509)
---
 mypy/checker.py                     |  5 ++++-
 test-data/unit/check-functions.test | 14 ++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/mypy/checker.py b/mypy/checker.py
index f478ce5757227..3107651c0107c 100644
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -960,7 +960,10 @@ def _visit_func_def(self, defn: FuncDef) -> None:
                 # Function definition overrides a variable initialized via assignment or a
                 # decorated function.
                 orig_type = defn.original_def.type
-                assert orig_type is not None, f"Error checking function redefinition {defn}"
+                if orig_type is None:
+                    # If other branch is unreachable, we don't type check it and so we might
+                    # not have a type for the original definition
+                    return
                 if isinstance(orig_type, PartialType):
                     if orig_type.type is None:
                         # Ah this is a partial type. Give it the type of the function.
diff --git a/test-data/unit/check-functions.test b/test-data/unit/check-functions.test
index bb36b65f35de2..ae6424f743be4 100644
--- a/test-data/unit/check-functions.test
+++ b/test-data/unit/check-functions.test
@@ -1475,6 +1475,20 @@ else:
     @dec
     def f(): pass
 
+[case testConditionalFunctionDefinitionUnreachable]
+def bar() -> None:
+    if False:
+        foo = 1
+    else:
+        def foo(obj): ...
+
+def baz() -> None:
+    if False:
+        foo: int = 1
+    else:
+        def foo(obj): ...  # E: Incompatible redefinition (redefinition with type "Callable[[Any], Any]", original type "int")
+[builtins fixtures/tuple.pyi]
+
 [case testConditionalRedefinitionOfAnUnconditionalFunctionDefinition1]
 from typing import Any
 def f(x: str) -> None: pass