Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PR review checklist #962

Open
ezio-melotti opened this issue Oct 7, 2022 · 3 comments
Open

Improve PR review checklist #962

ezio-melotti opened this issue Oct 7, 2022 · 3 comments

Comments

@ezio-melotti
Copy link
Member

In python/cpython#93823 (comment) @erlend-aasland wrote a checklist about reviewing PRs.

In #914 (comment), I suggested:

SGTM -- that's a nice list. I think it would be easier to add it in a separate PR though.
Reviewing PRs is currently documented in two places:

The former has been likely written from scratch after the HG->Git migration, whereas the latter formerly documented how to review patches attached to a bpo issue and then it has been adapted to GitHub. I think the best approach would be to enhance the pull-request-lifecycle with your list, and remove the duplicated info in triaging.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 10, 2022

Thanks for the PR! Can we close this?

@ezio-melotti
Copy link
Member Author

#914 only included the changes that I had initially created, and I now merged it to keep things moving incrementally like Diataxis suggests.
The checklist you suggested in the comment linked above is more comprehensive and can still be integrated in the devguide to improve the current checklist, so I opened this issue as a reminder.

@abdnafees
Copy link
Contributor

@ezio-melotti Can I please work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants