Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98644: point people to tomllib from configparser’s docs #98645

Merged
merged 2 commits into from
Oct 26, 2022
Merged

gh-98644: point people to tomllib from configparser’s docs #98645

merged 2 commits into from
Oct 26, 2022

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Oct 25, 2022 •
edited
Loading

Adds tomllib as first seealso entry to configparser’s docs, and discourage using JSON for that purpose.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 25, 2022
sobolevn
sobolevn approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Adding tomllib seems like a good idea. It totally needs more exposure, since it is so new.

@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label Oct 25, 2022
JelleZijlstra
JelleZijlstra reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions

Doc/library/configparser.rst Outdated Show resolved Hide resolved
Doc/library/configparser.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@flying-sheep @JelleZijlstra
Apply suggestions from code review
bf64335 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@flying-sheep
Copy link
Contributor Author

Both sound good, thanks!

@JelleZijlstra JelleZijlstra merged commit 5e74bad into python:main Oct 26, 2022
@miss-islington
Copy link
Contributor

Thanks @flying-sheep for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98721 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@flying-sheep @miss-islington
pythongh-98644: point people to tomllib from configparser’s docs (pyt…
6bd8b2c 
…honGH-98645)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 5e74bad)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @flying-sheep
gh-98644: point people to tomllib from configparser’s docs (GH-98645)
ca266aa 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 5e74bad)

Co-authored-by: Philipp A <flying-sheep@web.de>
@flying-sheep flying-sheep deleted the configparser-doc-fix branch October 28, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@sobolevn sobolevn sobolevn approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flying-sheep @miss-islington @bedevere-bot @JelleZijlstra @sobolevn