From c710eccc34eb726c81d2a2500ad9f3fb3166d31f Mon Sep 17 00:00:00 2001 From: STerliakov Date: Sat, 22 Oct 2022 16:56:28 +0300 Subject: [PATCH 1/2] Fix `-ne` shell operator spelling --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ba23c72586d49e..ccf03d0fc63bfc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -82,7 +82,7 @@ jobs: - name: Check for changes in the ABI run: | make check-abidump - if [ $? -neq 0 ] ; then + if [ $? -ne 0 ] ; then echo "Generated ABI file is not up to date." echo "Please, add the release manager of this branch as a reviewer of this PR." echo "" From cc29c8d7e1d3df7a263223dc2ba9ec1b3452a175 Mon Sep 17 00:00:00 2001 From: STerliakov Date: Tue, 25 Oct 2022 21:00:30 +0300 Subject: [PATCH 2/2] Mind `set -e` in github actions scripts --- .github/workflows/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ccf03d0fc63bfc..67a1d8018f3d20 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -81,8 +81,7 @@ jobs: make -j4 - name: Check for changes in the ABI run: | - make check-abidump - if [ $? -ne 0 ] ; then + if ! make check-abidump; then echo "Generated ABI file is not up to date." echo "Please, add the release manager of this branch as a reviewer of this PR." echo ""