Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988) #97575

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[3.8] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988) #97575

merged 1 commit into from
Oct 4, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 26, 2022 •
edited by bedevere-bot
Loading

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-96848: Fix -X int_max_str_digits option parsing (pythonGH-96988
8dcc5b3 
)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Sep 26, 2022
Merged
vstinner
vstinner approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ambv
Copy link
Contributor

ambv commented Oct 4, 2022

I re-ran the failing Windows test and it passed. Landing both this and GH-97574.

@ambv ambv merged commit 18a0cdb into python:3.8 Oct 4, 2022
@miss-islington miss-islington deleted the backport-4135166-3.8 branch October 4, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @ambv @vstinner @bedevere-bot