Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38723: Pdb._runscript should use io.open_code() instead of open() #17127

Merged
merged 3 commits into from
Nov 12, 2019
Merged

bpo-38723: Pdb._runscript should use io.open_code() instead of open() #17127

merged 3 commits into from
Nov 12, 2019

Conversation

jsnklln
Copy link
Contributor

@jsnklln jsnklln commented Nov 12, 2019 •
edited by bedevere-bot
Loading

From the io.open_code documentation:
This function should be used when the intent is to treat
the contents as executable code.

https://bugs.python.org/issue38723

bpo-38723: Pdb._runscript should use io.open_code() instead of open()
c1fceaf 
From the io.open_code documentation:
This function should be used when the intent is to treat
the contents as executable code.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jsnklln, @wcjsnklln

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher brandtbucher added the type-feature A feature request or enhancement label Nov 12, 2019
@brandtbucher
Copy link
Member

brandtbucher commented Nov 12, 2019 •
edited
Loading

Thanks for the PR @jsnklln!

I assume that you've seen the bot's message about the CLA? It looks like you may need BPO accounts (and signed CLAs) linked to each of the GitHub accounts it mentions above.

brandtbucher
brandtbucher requested changes Nov 12, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, I just have one suggestion to improve the NEWS entry:

Misc/NEWS.d/next/Library/2019-11-12-15-46-28.bpo-38723.gcdMFn.rst Outdated Show resolved Hide resolved
@jsnklln @brandtbucher
Update Misc/NEWS.d/next/Library/2019-11-12-15-46-28.bpo-38723.gcdMFn.rst
b7b630c 
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@jsnklln
Copy link
Contributor Author

jsnklln commented Nov 12, 2019

Yea I removed that extra account earlier this morning. I just ran the online checker again and the Ni Knights seem to say we're all good now. Thanks for the suggestion on NEWS, I've pressed the button that commits that change.

@brandtbucher
Copy link
Member

@zooba

@zooba zooba added the needs backport to 3.8 only security fixes label Nov 12, 2019
@zooba zooba merged commit d593881 into python:master Nov 12, 2019
@miss-islington
Copy link
Contributor

Thanks @jsnklln for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @jsnklln and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d593881505c1f4acfd17f41312b27cc898451816 3.8

@zooba zooba added needs backport to 3.8 only security fixes and removed needs backport to 3.8 only security fixes labels Nov 12, 2019
@miss-islington
Copy link
Contributor

Thanks @jsnklln for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17135 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Nov 12, 2019
miss-islington added a commit that referenced this pull request Nov 12, 2019
@miss-islington @jsnklln
bpo-38723: Pdb._runscript should use io.open_code() instead of open() (…
0a8e7fd 
…GH-17127)

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit d593881)

Co-authored-by: jsnklln <jsnklln@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@jsnklln @brandtbucher
bpo-38723: Pdb._runscript should use io.open_code() instead of open() (…
4463484 
…pythonGH-17127)

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@jsnklln @brandtbucher @shihai1991
bpo-38723: Pdb._runscript should use io.open_code() instead of open() (…
7d905a8 
…pythonGH-17127)

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@hauntsaninja hauntsaninja mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@zooba zooba

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jsnklln @the-knights-who-say-ni @brandtbucher @miss-islington @bedevere-bot @zooba