Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-89812: Add pathlib._PathBase #106337

Merged
merged 37 commits into from
Sep 30, 2023
Merged

GH-89812: Add pathlib._PathBase #106337

merged 37 commits into from
Sep 30, 2023

Commits on Jul 2, 2023

  1. Add pathlib._VirtualPath

    @barneygale
    barneygale committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    4b29e2e View commit details
    Browse the repository at this point in the history

  2. Add tests for pathlib._VirtualPath

    @barneygale
    barneygale committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    8ce0139 View commit details
    Browse the repository at this point in the history

  3. Fix tests on Windows

    @barneygale
    barneygale committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    b850d11 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Fix tests on Windows (take 2)

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    39bf6b3 View commit details
    Browse the repository at this point in the history

  2. Fix tests on Windows (take 3)

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0515dea View commit details
    Browse the repository at this point in the history

  3. Fix tests on Windows (take 4)

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    596016f View commit details
    Browse the repository at this point in the history

  4. Add tarfile.TarPath

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    1a6122b View commit details
    Browse the repository at this point in the history

  5. Add docs for tarfile.TarPath

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6833ed8 View commit details
    Browse the repository at this point in the history

  6. Add tests for tarfile.TarPath

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4d2e8a9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into pythongh-89812-omgtarpath

    @barneygale
    barneygale committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    e4daac9 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Merge branch 'main' into pythongh-89812-omgtarpath

    @barneygale
    barneygale committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e3f2509 View commit details
    Browse the repository at this point in the history

  2. Undo changes to tarfile.

    @barneygale
    barneygale committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    508cabe View commit details
    Browse the repository at this point in the history

  3. _VirtualPath --> _PathBase

    @barneygale
    barneygale committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2c56591 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'main' into pythongh-89812-omgtarpath

    @barneygale
    barneygale committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    42fe91a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
    @barneygale @AA-Turner
    barneygale and AA-Turner committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8944098 View commit details
    Browse the repository at this point in the history

  2. Improve _PathBase docstring

    @barneygale
    barneygale committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b61141a View commit details
    Browse the repository at this point in the history

  3. Explain use of nullcontext() in comment

    @barneygale
    barneygale committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1e462b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into pythongh-89812-omgtarpath

    @barneygale
    barneygale committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6318eb7 View commit details
    Browse the repository at this point in the history

  5. Align and test Path/PathBase docstrings

    @barneygale
    barneygale committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d321cad View commit details
    Browse the repository at this point in the history

  6. Revise _PathBase.is_junction()

    @barneygale
    barneygale committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    acfc1b0 View commit details
    Browse the repository at this point in the history

  7. Make is_junction() code more consistent with other is_*() methods.

    @barneygale
    barneygale committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bc82225 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Merge branch 'main' into pythongh-89812-omgtarpath

    @barneygale
    barneygale committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    9b6377a View commit details
    Browse the repository at this point in the history

  2. Improve UnsupportedOperation exception message.

    @barneygale
    barneygale committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    c3127b8 View commit details
    Browse the repository at this point in the history

  3. Slightly improve symlink loop code, exception message.

    @barneygale
    barneygale committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    3540ae1 View commit details
    Browse the repository at this point in the history

  4. Restore deleted comment in cwd(), expand _scandir() comment.

    @barneygale
    barneygale committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    c9f0f20 View commit details
    Browse the repository at this point in the history

  5. Make _PathBase.is_junction() immediately return false.

    @barneygale
    barneygale committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    0ee10ca View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. MAX_SYMLINKS --> _MAX_SYMLINKS

    @barneygale
    barneygale committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    17eee2f View commit details
    Browse the repository at this point in the history

  2. return self._unsupported() --> self._unsupported()

    @barneygale
    barneygale committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    c7c46bc View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. WIP

    @barneygale
    barneygale committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a51d7a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Undo test change. 

    This will require further refactoring in another PR.
    @barneygale
    barneygale committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7e3729e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge branch 'main' into pythongh-89812-omgtarpath

    @barneygale
    barneygale committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b945cf8 View commit details
    Browse the repository at this point in the history

  2. Ensure .. segments are resolved in non-strict mode

    @barneygale
    barneygale committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    703fe5c View commit details
    Browse the repository at this point in the history

  3. Move symlink loop resolution test from PosixPathTest to `DummyPathT… 

    …est`
    @barneygale
    barneygale committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e5e5be5 View commit details
    Browse the repository at this point in the history

  4. Add PathBase._split_stack() helper method.

    @barneygale
    barneygale committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    38769a0 View commit details
    Browse the repository at this point in the history

  5. Use path object as stat/link target cache key

    @barneygale
    barneygale committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7c78952 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Optimise resolve(): skip stat() in non-strict mode if readlink() is u… 

    …nsupported.
    @barneygale
    barneygale committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    fe57725 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Address code review comments

    @barneygale
    barneygale committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    cf9c8b6 View commit details
    Browse the repository at this point in the history