From b9600b0fbd71908f9fb3dd1bf78ebba6c4a16115 Mon Sep 17 00:00:00 2001 From: Shashank Parekh Date: Fri, 21 Jun 2019 08:32:22 +0530 Subject: [PATCH] Remove redundant if check from optional argument function in argparse. (GH-8766) --- Lib/argparse.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Lib/argparse.py b/Lib/argparse.py index 9a67b41ae00ead..4f3aea928bf6f4 100644 --- a/Lib/argparse.py +++ b/Lib/argparse.py @@ -1479,10 +1479,8 @@ def _get_optional_kwargs(self, *args, **kwargs): # strings starting with two prefix characters are long options option_strings.append(option_string) - if option_string[0] in self.prefix_chars: - if len(option_string) > 1: - if option_string[1] in self.prefix_chars: - long_option_strings.append(option_string) + if len(option_string) > 1 and option_string[1] in self.prefix_chars: + long_option_strings.append(option_string) # infer destination, '--foo-bar' -> 'foo_bar' and '-x' -> 'x' dest = kwargs.pop('dest', None)