-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: should trio.ssl be imported by default? #199
Comments
Might make sense to either have the open function be part of the ssl module, alternatively have a function for "loading" the ssl module that's required to be run before you're allowed to run |
That's a plausible option too, yeah, good point. It looks like twisted is not terribly worried about this – if you use their |
It's also possible to make Before doing anything drastic it's probably also worth checking how much memory openssl actually uses if you haven't called |
Neither approach is terribly scary. I guess we can close this until someone runs into the issue for real, and then we can ask them which approach they prefer. |
Currently it is. Glyph says that's bad, because there are cases where you have lots of tiny processes stuffed onto a box and openssl is kinda memory hungry, so it's better not to load the
ssl
module until you have to.I'm not super-opposed to making people
import trio.ssl
, but if we have a high-leveltrio.open_ssl_tcp_stream(...)
function then it may take some awkward work to avoid importing it early. And I'm not a big fan of the idea that calling that function would implicitly causetrio.ssl
to materialize in the user-visible namespace.The text was updated successfully, but these errors were encountered: