From d5b7694d045a793ee10680b060ade3c629e7f7ab Mon Sep 17 00:00:00 2001 From: "Edward K. Ream" Date: Tue, 3 Jan 2023 16:07:14 -0600 Subject: [PATCH 1/2] Replace eval with a dict --- rope/contrib/generate.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/rope/contrib/generate.py b/rope/contrib/generate.py index 3974162f1..667d867b4 100644 --- a/rope/contrib/generate.py +++ b/rope/contrib/generate.py @@ -18,7 +18,14 @@ def create_generate(kind, project, resource, offset, goal_resource=None): 'package'. """ - generate = eval("Generate" + kind.title()) + d = { + 'class': GenerateClass, + 'function': GenerateFunction, + 'module': GenerateModule, + 'package': GeneratePackage, + 'variable': GenerateVariable, + } + generate = d.get(kind) return generate(project, resource, offset, goal_resource=goal_resource) From 626d7747fad73ee415760dbf2b95337f3c244957 Mon Sep 17 00:00:00 2001 From: "Edward K. Ream" Date: Tue, 3 Jan 2023 16:13:45 -0600 Subject: [PATCH 2/2] Blacken --- rope/contrib/generate.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rope/contrib/generate.py b/rope/contrib/generate.py index 667d867b4..3546f19c6 100644 --- a/rope/contrib/generate.py +++ b/rope/contrib/generate.py @@ -19,11 +19,11 @@ def create_generate(kind, project, resource, offset, goal_resource=None): """ d = { - 'class': GenerateClass, - 'function': GenerateFunction, - 'module': GenerateModule, - 'package': GeneratePackage, - 'variable': GenerateVariable, + "class": GenerateClass, + "function": GenerateFunction, + "module": GenerateModule, + "package": GeneratePackage, + "variable": GenerateVariable, } generate = d.get(kind) return generate(project, resource, offset, goal_resource=goal_resource)