Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better internal structure for QDForest #12

Open
smarie opened this issue Jan 27, 2021 · 2 comments
Open

Better internal structure for QDForest #12

smarie opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@smarie
Copy link
Contributor

smarie commented Jan 27, 2021 •
edited
Loading

Currently QDForest can either be created from an adjmat or a parents array. Is this the most optimal ?
We should probably use a scipy.sparse structure or two instead.

This should be tailored to usage:

  • get_arcs method should be efficient for QDSelectorModel.fit(X)
  • walk_arcs method should be efficient for QDSelectorModel.predict_qd(X)
@smarie smarie added the enhancement New feature or request label Jan 27, 2021
@smarie smarie changed the title Investigate performance in QDForest Better internal structure for QDForest Jan 27, 2021
@smarie
Copy link
Contributor Author

smarie commented Jan 27, 2021

Also concerning names (and dtypes in the future ?), it is probably better to do all the work on arrays, and to remember a map index -> name and dtype.

@smarie
Copy link
Contributor Author

smarie commented Jan 27, 2021

https://github.com/caesar0301/treelib

and

https://networkx.org/

might help also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarie