Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing pytest on py2.7 doesn't pick up more-itertools #907

Closed
3 tasks done
cjw296 opened this issue Feb 21, 2019 · 4 comments · Fixed by #2361
Closed
3 tasks done

installing pytest on py2.7 doesn't pick up more-itertools #907

cjw296 opened this issue Feb 21, 2019 · 4 comments · Fixed by #2361
Labels
area/installer Related to the dependency installer area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Milestone

Comments

@cjw296
Copy link

cjw296 commented Feb 21, 2019

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

build environment: https://circleci.com/gh/cjw296/playground/9
config: https://github.com/cjw296/playground/blob/48364861386eeda9d2592423503fe1c50b94cf1b/pyproject.toml

Issue

poetry fails to install more-itertools on python 2.7, even though it's a dependency of pytest.
The workaround is to separately specify it:

cjw296/playground@035f8b5

Looks like the pytest guys had some fun with this too, so suspect it might be a nasty
edge case: pytest-dev/pytest#4770

@sdispater
Copy link
Member

This is still a bug in Poetry though.

Poetry properly locks more-itertools (5.0.0) with the environment markers python_version <= "2.7" or python_version > "2.7" which basically mean any Python version. However for some reason, it skips more-itertools when selecting what to install for Python 2.7: Skipping more-itertools (5.0.0) Not needed for the current environment which is obviously wrong.

I think this is an issue in the installer when resolving packages using the lock file where it seems to drop the python_version <= "2.7" marker.

@sdispater sdispater added kind/bug Something isn't working as expected area/solver Related to the dependency resolver area/installer Related to the dependency installer labels Feb 21, 2019
@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Nov 13, 2019
@abn abn added this to the 1.1 milestone Apr 29, 2020
@abn abn linked a pull request Apr 29, 2020 that will close this issue
2 tasks
@abn abn closed this as completed Sep 19, 2020
@md384
Copy link
Contributor

md384 commented Apr 30, 2021

@sdispater @abn can we re-open this ticket? I am still seeing this issue in 1.1.6. Actually happened to me when, I removed an unrelated dependency via poetry remove.

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants