Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subdirectory to poetry VCS configs #5272

Closed
2 tasks done
rickmark opened this issue Mar 3, 2022 · 2 comments
Closed
2 tasks done

Add subdirectory to poetry VCS configs #5272

rickmark opened this issue Mar 3, 2022 · 2 comments
Labels
kind/feature Feature requests/implementations status/duplicate Duplicate issues

Comments

@rickmark
Copy link

rickmark commented Mar 3, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Some projects (e.g. unicorn-engine/unicorn) place python projects into subdirectories as they support bindings in multiple languages. Today we cannot add this as a Git VCS url to a project because setup.py is not at the root but instead at a path of bindings/python/setup.py relative to the VCS root.

Also, the error messages for the above are non-intuitive. VCS poetry projects should check for setup.py or pyproject.toml and provide helpful messages that they could not be found in the the VCS root.

We should be mindful that we do not want to check out the subdirectory from VCS as a treeish as many will do .. navigation to shared resources. (Again, Unicorn as an example)

@rickmark rickmark added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Mar 3, 2022
@finswimmer
Copy link
Member

Hello @rickmark,

this is a duplicate of #755.

fin swimmer

@finswimmer finswimmer added the status/duplicate Duplicate issues label Mar 4, 2022
@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Jun 11, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/duplicate Duplicate issues
Projects
None yet
Development

No branches or pull requests

3 participants