Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 517 config settings #5202

Closed
2 tasks done
yajo opened this issue Feb 15, 2022 · 5 comments
Closed
2 tasks done

Support PEP 517 config settings #5202

yajo opened this issue Feb 15, 2022 · 5 comments
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@yajo
Copy link

yajo commented Feb 15, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

PEP517 declares support for something called "config settings", which allows passing arbitrary parameters to the build backend, allowing to specify custom logic for it.

Pip doesn't support it yet, but there's a proposal.

Build supports it.

Poetry should support it.

@yajo yajo added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Feb 15, 2022
@finswimmer
Copy link
Member

finswimmer commented Feb 15, 2022

Hello @yajo,

pip, build and poetry have very different goals. Saying tool X provides function Y and so poetry should do as well, doesn't help much. Can you provide a use case / user story to show what you expect from poetry here?

fin swimmer

@yajo
Copy link
Author

yajo commented Feb 15, 2022

Yes, I would like to be able to produce one single pip package that, with those config settings, allows installing different portions of the repo.

For example, for OCA (odoo) addons, currently each repo has a setup folder with a specific structure that is autogenerated and allows installing addons separately.

Example: this directory should be installable with:

poetry add git+https://github.com/OCA/project.git#subdirectory=setup/project_task_personal_stage_auto_fold

(It is not AFAIK; see #755).

Instead, I'd like to be able to have a single setup.py file that generates installation scripts automatically for each addon, and makes them installable with:

poetry add git+https://github.com/OCA/project.git --config-settings addon=project_task_personal_stage_auto_fold

I'm not sure if poetry itself would serve for generating such dynamic package, but at least it should work for installing it.

@neimad1985
Copy link

@yajo I kindly think that you should stop telling people what they should do or not. No pun intended. This would prevent you from getting a stalling issue.

@yajo
Copy link
Author

yajo commented Dec 18, 2022

Sorry I didn't mean to offend anyone 😔

I'll close the issue so maintainers can focus on whatever they think it's better for the project.

Thanks everybody!

@yajo yajo closed this as completed Dec 18, 2022
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants