Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry new is not using recommended pattern for __version__ variable #4238

Closed
polvoazul opened this issue Jun 30, 2021 · 2 comments
Closed

Comments

@polvoazul
Copy link

Closing this as importlib.metadata is the way to go. A possible pattern to support python <3.8 and >=3.8 I described here.

If this is the recommended solution, then poetry new should be updated to use it. Currently, the poetry new command adds __version__ to __init__.py, but then poetry version doesn't update it. This incompatibility between the two commands is confusing for me, and I imagine other newcomers.

Originally posted by @albrow in #144 (comment)

@finswimmer
Copy link
Member

finswimmer commented Jul 4, 2021

Hello @polvoazul,

with poetry 1.2.0a1 poetry will not add any __version__ to the __init__.py. (#2768)

fin swimmer

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants