Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option for get-poetry.py to only install _vendor dependencies for the current Python version. #3819

Closed
2 tasks done
ruohola opened this issue Mar 21, 2021 · 4 comments · Fixed by #3706
Closed
2 tasks done
Labels
kind/feature Feature requests/implementations

Comments

@ruohola
Copy link
Contributor

ruohola commented Mar 21, 2021

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Currently the get-poetry.py install script installs Poetry's dependencies for Python versions 2.7, 3.5, 3.6, 3.7, 3.8, and 3.9 to .poetry/lib/poetry/_vendor/, and they all take around 30MB each. This is annoying when trying to make minimal Docker images. Could there be an environment variable or another configuration option to only install these for the currently used Python version?

@ruohola ruohola added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Mar 21, 2021
@ruohola
Copy link
Contributor Author

ruohola commented Mar 21, 2021

In the meantime, I've been using:

find /home/user/.poetry/lib/poetry/_vendor/ -mindepth 1 -maxdepth 1 -not -name py3.9 -type d | xargs rm -rf 

in my Dockerfiles.

@abn
Copy link
Member

abn commented Mar 21, 2021

This should go away with the new bootstrapping mechanism (see #3706). Feel free to test it out. Additionally, you could simply use pip install poetry in your Dockerfile.

@abn abn linked a pull request Mar 21, 2021 that will close this issue
2 tasks
@ruohola
Copy link
Contributor Author

ruohola commented Mar 21, 2021

This should go away with the new bootstrapping mechanism (see #3706).

Looks promising, thanks!

Additionally, you could simply use pip install poetry in your Dockerfile.

Yeah I know, but I really like the fact that by installing with the get-poetry.py script Poetry's own dependencies are completely isolated from my other packages.

@abn abn closed this as completed in #3706 Mar 30, 2021
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants