Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Specific dependencies #2479

Closed
2 tasks done
nihaals opened this issue May 30, 2020 · 4 comments · Fixed by #5815
Closed
2 tasks done

OS Specific dependencies #2479

nihaals opened this issue May 30, 2020 · 4 comments · Fixed by #5815
Labels
area/docs Documentation issues/improvements kind/feature Feature requests/implementations

Comments

@nihaals
Copy link
Contributor

nihaals commented May 30, 2020

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

StackOverflow post for non-poetry specific case
It may be useful to expand this to OS specific wheels with different code in case the project can't easily be made universal. If this approach is used, there may be a separate table in the config file for each OS where you can select a different package directory.
Some packages also have requirements for certain versions of Python, usually backports, which would be helpful here too.

@nihaals nihaals added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels May 30, 2020
@nihaals
Copy link
Contributor Author

nihaals commented Jun 4, 2020

It looks like this is covered in markers. Maybe this should be referenced on the pyproject.toml page where people would expect it?

@finswimmer finswimmer added the area/docs Documentation issues/improvements label Jun 6, 2020
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
@nihaals
Copy link
Contributor Author

nihaals commented May 22, 2022

Is this a won't fix? Maybe a more general solution would be linking to dependency specification in dependenciesand dev-dependencies as it includes more relevant information and can be missed when looking at the pyproject.toml reference.

@Secrus
Copy link
Member

Secrus commented May 22, 2022

Is this a won't fix? Maybe a more general solution would be linking to dependency specification in dependenciesand dev-dependencies as it includes more relevant information and can be missed when looking at the pyproject.toml reference.

You are welcome to make a PR adding this link.

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants