Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_vcs fails if git is not installed #2107

Closed
3 tasks done
jr314159 opened this issue Feb 28, 2020 · 3 comments · Fixed by #2105
Closed
3 tasks done

get_vcs fails if git is not installed #2107

jr314159 opened this issue Feb 28, 2020 · 3 comments · Fixed by #2105
Labels
kind/bug Something isn't working as expected

Comments

@jr314159
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

I am using poetry with tox. This commit breaks tox+poetry in an environment where git is not installed. ab66bb9

Reverting to version 1.0.3 solves the issue.

My tox.ini looks like this:

[tox]
isolated_build = true
envlist = py37

[testenv]
deps = poetry
commands =
    poetry install -v
    poetry run pytest -s --doctest-modules
@jr314159 jr314159 added the kind/bug Something isn't working as expected label Feb 28, 2020
jr314159 referenced this issue Feb 28, 2020
@finswimmer
get_vcs starts searching git folder from tmp dir instead of project (#…
ab66bb9 
…1946) (#1947)

* fix (builder): take `self._original_path` if available to find `.git` folder

* change (vcs): use `git rev-parse --show-toplevel` to find git root folder

* fix (vcs): change back to original working dir after finding vcs

* change (builder): introduce self._original_path to keep original path
if(vcs): resolve directory for `get_vcs`
@jr314159 jr314159 mentioned this issue Feb 28, 2020
Closed
3 tasks
@funkyfuture
Copy link
Contributor

i think poetry shouldn't depend on an expected binary, but rather use dulwich or another Python library.

@jr314159
Copy link
Author

Ah looks like #2105 will resolve this once merged

@adisbladis adisbladis mentioned this issue Feb 29, 2020
Merged
@funkyfuture funkyfuture mentioned this issue Feb 29, 2020
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix VCS when git is not in PATH adisbladis/poetry
2 participants
@jr314159 @funkyfuture