Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing output for install sub-command #1471

Closed
3 tasks done
pikeas opened this issue Oct 17, 2019 · 2 comments · Fixed by #1528
Closed
3 tasks done

Confusing output for install sub-command #1471

pikeas opened this issue Oct 17, 2019 · 2 comments · Fixed by #1528
Labels
area/docs Documentation issues/improvements

Comments

@pikeas
Copy link

pikeas commented Oct 17, 2019

Issue

$ poetry install
Installing dependencies from lock file

Nothing to install or update

  - Installing foo (0.1.0)
$ poetry install -vvv
Using virtualenv: /Users/pikeas/Library/Caches/pypoetry/virtualenvs/foo-0mmka8-W-py3.7
Installing dependencies from lock file

Nothing to install or update

  - Skipping more-itertools (7.2.0) Already installed
  - Skipping zipp (0.6.0) Already installed
  - Skipping importlib-metadata (0.23) Already installed
  - Skipping atomicwrites (1.3.0) Already installed
  - Skipping attrs (19.3.0) Already installed
  - Skipping colorama (0.4.1) Not needed for the current environment
  - Skipping pluggy (0.13.0) Already installed
  - Skipping py (1.8.0) Already installed
  - Skipping six (1.12.0) Already installed
  - Skipping pytest (3.10.1) Already installed
  - Installing foo (0.1.0)

It is quite confusing to see a message saying "nothing to install" immediately followed by a message saying something is being installed!

@pikeas pikeas added the kind/bug Something isn't working as expected label Oct 17, 2019
@finswimmer
Copy link
Member

finswimmer commented Oct 17, 2019

I can think of why this is confusing. But the "Nothing to install" is the answer to "Installing dependencies". foo is not a dependency but the project package. So the wording is not wrong in my opinion.

One could make it more clearer by printing "No dependencies to install or update".

@brycedrennan brycedrennan added area/docs Documentation issues/improvements and removed kind/bug Something isn't working as expected labels Oct 17, 2019
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants