Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython Extensions #137

Closed
frnkvieira opened this issue May 24, 2018 · 6 comments
Closed

Cython Extensions #137

frnkvieira opened this issue May 24, 2018 · 6 comments

Comments

@frnkvieira
Copy link

Hello! Firstly, this project is awesome.

I'm a heavy user of C extensions and Cython modules but they are specified in the setup.py file to be compiled to native code at install time. I'm not sure if they should be specified in "pyproject.toml" because even in the PEP there are no mentions to it. I'm willing to do a pull request if needed so I just need a direction :)

Keep the great work, many thanks!

@emmatyping
Copy link

emmatyping commented Jun 15, 2018

AIUI, this would require Cython to create a build backend as specified in https://www.python.org/dev/peps/pep-0517. Then poetry would "just" need to add support for PEP 517.

@emmatyping
Copy link

It seems like currently you can use the undocumented (unstable) build.py like in #11.

@salotz
Copy link

salotz commented Oct 11, 2018

I added an example on using cython in #11. Cython probably wouldn't have to have the build backend (except as a library which it basically already has in the form of cythonize). From how I understand PEP 517 only one build backend is allowed anyhow since the 'build-backend' is just a single string and Cython would never be the only build backend. So poetry, flit, or (more likely) pip will be the build backend. That is unless poetry takes the place of pip. For instance if you try to install that package I made with pip from source you need to have Cython already installed without the PEP 518 requires = ['setuptools', 'wheel' 'Cython'] which pip supports now and installs cython before building.

@salotz
Copy link

salotz commented Oct 11, 2018

So this issue can be closed if poetry can be used as a build backend. How that is implemented (build.py etc.) is another issue probably.

@kasteph
Copy link
Member

kasteph commented May 31, 2019

Closing this issue, see solutions (by @sdispater and @salotz in #11).

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants