Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression with duplicating dependency with extra #129

Closed
4 tasks done
tnydg99 opened this issue Sep 30, 2022 · 4 comments
Closed
4 tasks done

Possible regression with duplicating dependency with extra #129

tnydg99 opened this issue Sep 30, 2022 · 4 comments
Labels
question Further information is requested

Comments

@tnydg99
Copy link

tnydg99 commented Sep 30, 2022

  • Poetry version: 1.2.1

  • Python version: 3.8.9

  • OS version and name: macOS 12.6

  • pyproject.toml: https://gist.github.com/tnydg99/0b018320ae7d2a6600a81f9d2d04d92c

  • I am on the latest stable Poetry version, installed using a recommended method.

  • I have searched the issues of this repo and believe that this is not a duplicate.

  • I have consulted the FAQ and blog for any relevant entries or release notes.

  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

When using v1.2.x of Poetry, the export command seems to be duplicating the same dependency, but with lines containing extras and lines not containing extras in the output requirements.txt file. In this example, google-api-core is one that is duplicate with both google-api-core and google-api-core[grpc]. This happens with or without including hashes. This is behavior specific to v1.2.x, as 1.1.x (up to latest release of 1.1.15) does not replicate this behavior.

Attached comparable requirements.txt files

requirements_115.txt
requirements_121.txt

@dimbleby
Copy link
Contributor

dimbleby commented Oct 1, 2022

Not a bug, python-poetry/poetry#5688 (comment)

@neersighted neersighted added the question Further information is requested label Oct 1, 2022
@tnydg99
Copy link
Author

tnydg99 commented Oct 2, 2022

Not a bug, python-poetry/poetry#5688 (comment)

@dimbleby I just want to make sure I understand the comment, but in python-poetry/poetry#5688, the markers were different and having two different lines made sense. But in this case, the markers are the exact same.

google-api-core==2.10.1 ; python_full_version >= "3.7.3" and python_version < "3.10"
google-api-core[grpc]==2.10.1 ; python_full_version >= "3.7.3" and python_version < "3.10"

Based on these being the same markers, is this still the correct behavior?

@dimbleby
Copy link
Contributor

dimbleby commented Oct 2, 2022

arguably this could be deduplicated down to just google-api-core[grpc] but I know of no reason to care about this.

Are you seeing an actual problem or is this just a question about cosmetics?

@tnydg99
Copy link
Author

tnydg99 commented Oct 2, 2022

I am seeing an issue integrating with a module independent of poetry, which complains about duplication in an input requirements.txt file. But at that point, it's no longer for poetry to care about, so I think your conclusion is sufficient for resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants