-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test: test_qt_image_qapplication.py::test_sanity #6875
Comments
I ran the test suite repeatedly in GitHub Actions, and managed to have the There are three short lines of incorrect pixels in the image. If that is acceptable, then PR #6915 relaxes the check so that this image would have passed. However, it's not just during |
Thank you, #6915 merged! |
I've run our test suite in Ubuntu on GitHub Actions several thousand times since the PR was merged, and haven't seen any further errors. Maybe this I think if we wait a while, and this hasn't re-occurred, then this can be closed. |
It's been a month since #6970 was merged, and I haven't seen any of these failures since. I think this can be closed. |
Agreed, thank you very much! |
test_sanity
intest_qt_image_qapplication.py
is a flaky test that intermittently fails. It often passes when restarted.It would be good to fix this: fix/rewrite the test, or the code if the problem is there, or maybe even remove it. There are also pytest plugins to re-run flaky tests a number of times.
The failure
The logs
Here's two failures from a single PR:
ubuntu-latest Python 3.10
https://github.com/python-pillow/Pillow/actions/runs/3876084636/jobs/6609487729
Full logs: macos-ubuntu.zip
MSYS2 MinGW 32-bit
https://github.com/python-pillow/Pillow/actions/runs/3876084639/jobs/6609486139#logs
Full logs: mingw.zip
The test
Pillow/Tests/test_qt_image_qapplication.py
Lines 54 to 92 in 50f7888
The text was updated successfully, but these errors were encountered: