From 9f86718f4fa8573dccf5f1c004b977b04ec9a624 Mon Sep 17 00:00:00 2001 From: Dmitry Dygalo Date: Wed, 15 Dec 2021 21:21:58 +0100 Subject: [PATCH] perf: Use cached lookups for resolving fragments if the referent document is known --- CHANGELOG.rst | 1 + jsonschema/validators.py | 20 +++++++++++++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 507b112d0..a57e5ba91 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -4,6 +4,7 @@ v4.3.0 * Fix undesired fallback to brute force container uniqueness check on certain input types (#893) * Cache reference lookups for subschemas (#893) +* Use cached lookups for resolving fragments if the referent document is known (#893) * Implement a PEP544 Protocol for validator classes (#890) v4.2.1 diff --git a/jsonschema/validators.py b/jsonschema/validators.py index 46cd8e10a..93c292983 100644 --- a/jsonschema/validators.py +++ b/jsonschema/validators.py @@ -757,6 +757,10 @@ def resolving(self, ref): finally: self.pop_scope() + @lru_cache() + def _find_in_referrer(self, key): + return list(self._finditem(self.referrer, key)) + def _finditem(self, schema, key): values = deque([schema]) while values: @@ -773,8 +777,11 @@ def _find_subschemas(self): @lru_cache() def _find_in_subschemas(self, url): + subschemas = self._find_subschemas() + if not subschemas: + return None uri, fragment = urldefrag(url) - for subschema in self._find_subschemas(): + for subschema in subschemas: target_uri = self._urljoin_cache( self.resolution_scope, subschema["$id"], ) @@ -831,12 +838,19 @@ def resolve_fragment(self, document, fragment): if not fragment: return document + if document is self.referrer: + find = self._find_in_referrer + else: + + def find(key): + return self._finditem(document, key) + for keyword in ["$anchor", "$dynamicAnchor"]: - for subschema in self._finditem(document, keyword): + for subschema in find(keyword): if fragment == subschema[keyword]: return subschema for keyword in ["id", "$id"]: - for subschema in self._finditem(document, keyword): + for subschema in find(keyword): if "#" + fragment == subschema[keyword]: return subschema