intword with negative numbers

[maxrioux100]

What did you do?

import humanize
print(humanize.intword(-1000000000))

What did you expect to happen?

-1.0 billion

What actually happened?

-1000000000

What versions are you using?

• OS: Windows 10
• Python: 3.10.4
• Humanize: 3.14

[hugovk]

Thanks, I'd be open to a PR.

[maxrioux100]

import humanize
def with_negative(number):
    negative = number < 0
    if negative : number *= -1
    word = humanize.intword(number)
    if negative : word = f'-{word}'
    return word
print(with_negative(-1000000000)) 

Something like that (I wrote it in the browser without testing so it may have some typos)

[carterbox]

By opening a PR, hugovk means open a pull-request with some changes to the source code of humanize, not writing a new function that wraps around the existing humanize API.

[maxrioux100]

def intword(value, format="%.1f"):
    """Converts a large integer to a friendly text representation.
    Works best for numbers over 1 million. For example, 1_000_000 becomes "1.0 million",
    1200000 becomes "1.2 million" and "1_200_000_000" becomes "1.2 billion". Supports up
    to decillion (33 digits) and googol (100 digits).
    Examples:
        ```pycon
        >>> intword("100")
        '100'
        >>> intword("12400")
        '12.4 thousand'
        >>> intword("1000000")
        '1.0 million'
        >>> intword(1_200_000_000)
        '1.2 billion'
        >>> intword(8100000000000000000000000000000000)
        '8.1 decillion'
        >>> intword(None) is None
        True
        >>> intword("1234000", "%0.3f")
        '1.234 million'
        ```
    Args:
        value (int, float, str): Integer to convert.
        format (str): To change the number of decimal or general format of the number
            portion.
    Returns:
        str: Friendly text representation as a string, unless the value passed could not
        be coaxed into an `int`.
    """
    try:
        value = int(value)
    except (TypeError, ValueError):
        return value

    negative = value < 0
    if negative : value *= -1
    
    if value < powers[0]:
        return str(value)
    for ordinal, power in enumerate(powers[1:], 1):
        if value < power:
            chopped = value / float(powers[ordinal - 1])
            if float(format % chopped) == float(10**3):
                chopped = value / float(powers[ordinal])
                singular, plural = human_powers[ordinal]
                return (
                    " ".join([format, _ngettext(singular, plural, math.ceil(chopped))])
                ) % chopped
            else:
                singular, plural = human_powers[ordinal - 1]
                return (
                    " ".join([format, _ngettext(singular, plural, math.ceil(chopped))])
                ) % chopped

     if negative : value = f'-{value}'

    return str(value)

It was just to help you. Here is a better version. Not on my computer so I don't have access to git

[maxrioux100]

@pytest.mark.parametrize(
    "test_args, expected",
    [
        (["100"], "100"),
        (["1000"], "1.0 thousand"),
        (["12400"], "12.4 thousand"),
        (["12490"], "12.5 thousand"),
        (["1000000"], "1.0 million"),
        (["1200000"], "1.2 million"),
        (["1290000"], "1.3 million"),
        (["999999999"], "1.0 billion"),
        (["1000000000"], "1.0 billion"),
        (["2000000000"], "2.0 billion"),
        (["999999999999"], "1.0 trillion"),
        (["1000000000000"], "1.0 trillion"),
        (["6000000000000"], "6.0 trillion"),
        (["999999999999999"], "1.0 quadrillion"),
        (["1000000000000000"], "1.0 quadrillion"),
        (["1300000000000000"], "1.3 quadrillion"),
        (["3500000000000000000000"], "3.5 sextillion"),
        (["8100000000000000000000000000000000"], "8.1 decillion"),
        (["-100"], "-100"),
        (["-1000"], "-1.0 thousand"),
        (["-12400"], "-12.4 thousand"),
        (["-12490"], "-12.5 thousand"),
        (["-1000000"], "-1.0 million"),
        (["-1200000"], "-1.2 million"),
        (["-1290000"], "-1.3 million"),
        (["-999999999"], "-1.0 billion"),
        (["-1000000000"], "-1.0 billion"),
        (["-2000000000"], "-2.0 billion"),
        (["-999999999999"], "-1.0 trillion"),
        (["-1000000000000"], "-1.0 trillion"),
        (["-6000000000000"], "-6.0 trillion"),
        (["-999999999999999"], "-1.0 quadrillion"),
        (["-1000000000000000"], "-1.0 quadrillion"),
        (["-1300000000000000"], "-1.3 quadrillion"),
        (["-3500000000000000000000"], "-3.5 sextillion"),
        (["-8100000000000000000000000000000000"], "-8.1 decillion"),
        ([None], None),
        (["1230000", "%0.2f"], "1.23 million"),
        ([10**101], "1" + "0" * 101),
    ],
)