-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension submodules #55
Add extension submodules #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include some extensions because they were extremely out of date or simple not worth the time
Which ones? Maybe we should update the Readme with information about which extensions are included and which are not?
this is definitely not backwards compatible, because of this I suggest that when this branch is merged we release it as v2
I agree. That was going to be my suggestion, too.
I also haven't tested the custom variables some of the extensions use.
That's okay, this was never tested before the initial v1.0 release either. If someone runs into a problem with them, they can open a bug report.
adding new extensions should only be a matter of running
Wouldn't you also have to change the MANIFEST.in
file? I'm wondering if maybe we should document how to add these additional submodules in the wiki or something.
Overall this looks great. Nice work, and thanks for the PR. I just have a couple of nitpicks and one suggestion for a feature removal.
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
That depends on the extension. Out of 19 extensions I only needed a special case for two in the
Some where duplicates (like steps and tags-input), another is the iconpicker that doesn't even work on the website. The dashboard and blocklist ones are also excluded, I think i had some trouble making them work. The spacing extension became obsolete in Bulma v0.9.0. |
The readme currently says we use Bulma-Extensions v4.0.0, but I'm unsure of where this number comes from, considering each extension has its own version control. |
it may have been the npm package number at the time. Seems that's at 6.2.4 now. Would be better to just include a list of which specific extensions we do support, though. That's probably the final thing I'd like to see in this PR before merging. And obviously version isn't really erlevant anymore now with the submodules. It'll be whatever was the latest version when the last release happened. We can do releases now and then to bump these versions. |
I remember now that the iconpicker extension doesn't work because it uses a fontawesome cdn for version 4 that now responds with 404, probably because it is no longer supported. |
excellent! |
Further work on #42
Closes #7
I didn't include some extensions because they were extremely out of date or simple not worth the time. Most of the extensions are made by the same guy, so their directory structure all match up, but others have wildly differing setups. I tried my best to have it figure out what files are relevant, meaning adding new extensions should only be a matter of running:
Since i removed the old extensions, this is definitely not backwards compatible, because of this I suggest that when this branch is merged we release it as v2 or at least v1.4. Also, the way I've been testing is with one big file with all the extensions, which is only a visual verification. I also haven't tested the custom variables some of the extensions use.