Add Python 3.10 support #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euresti
reviewed
Feb 19, 2021
| """ | ||
| String annotations are passed into __init__ as is. | ||
|
|
||
| It fails on 3.6 due to a bug in Python. |
There was a problem hiding this comment.
TypeError: Forward references must evaluate to types. Got typing.ClassVar[int].
| @@ -487,10 +518,6 @@ class C: | |||
| y = attr.ib(type=str) | |||
| z = attr.ib() | |||
|
|
|||
| assert "int" == attr.fields(C).x.type | |||
There was a problem hiding this comment.
Because they don't work across Python versions (they become typing.ForwardRef or something like that). I figured it's more important it ultimately gives us what we need?
| @@ -624,9 +624,8 @@ def test_init(self, slots, frozen): | |||
| with pytest.raises(TypeError) as e: | |||
| C(a=1, b=2) | |||
|
|
|||
| assert ( | |||
| assert e.value.args[0].endswith( | |||
There was a problem hiding this comment.
Interesting. What does it start with now?
There was a problem hiding this comment.
The class names. So in this case C..
|
The tests have totally finished and succeeded. sigh |
hynek
force-pushed
the
py310
branch
2 times, most recently
from
0d5ecdc to
939742f
Compare
Python 3.10 has string types everywhere and that has unmasked a bunch of bugs/edge cases in our code. Especially the hooks code need a resolving helper for string types. I'm leaving that for a separate PR. Fixes #716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.10 has string types everywhere and that has unmasked a bunch of
bugs/edge cases in our code.
Especially the hooks code need a resolving helper for string types. I'm leaving
that for a separate PR.
Same for test_mypy.yml
Fixes #716
cc @euresti @ambv @frenzymadness @sscherfke