-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress HealthCheck.too_slow for test_not_none_metadata #364
Conversation
On very slow hardware, these may time out. Bug: https://bugs.gentoo.org/651794
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 831 831
Branches 174 174
=====================================
Hits 831 831 Continue to review full report at Codecov.
|
It might be better to have a global thing like: settings.register_profile(
"patience", settings(suppress_health_check=[HealthCheck.too_slow])
)
settings.load_profile("patience") And make the |
Yeah I think I agree with @wsanchez here. Trying to suppress only certain tests is a game of whac-a-mole. It should be all or none. |
Then push the relevant changes please? |
@hynek: Should we suppress these all the time or try to limit that to CI environments (eg. "CI" env var is set)? I kinda lean towards the former; wall-clock timeouts like these aren't my favorite. |
Hm ISTM that it’s kind of a feature in local dev that some tests are not optimal. So I’d tend to an env var. But would like input from @Tinche and @DRMacIver on it. |
* Disable hypothesis.HealthCheck.too_slow globally Fixes #364 * Add newsfragment
On very slow hardware, these may time out.
Bug: https://bugs.gentoo.org/651794