Fix the repr to work for non-redecorated subclass. #20

cyli · 2015-07-21T23:26:39Z

Currently, if you subclass an @attr.s-decorated class without re-decorating with another @attr.s, the repr displays the name of the superclass, not the subclass.

…e subclass, not the superclass, even if you don't redecorate with another @attr.s

codecov-io · 2015-07-21T23:27:14Z

Current coverage is `100.0%`

Merging #20 into master will not affect coverage as of 17e5460

@@            master     #20   diff @@
======================================
  Files            6       6       
  Stmts          299     299       
  Branches        59      59       
  Methods          0       0       
======================================
  Hit            299     299       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff

Powered by Codecov

Fix the repr to work for non-redecorated subclass.

hynek · 2015-07-22T14:33:59Z

Thanks!

If you subclass an attr class, the repr should include the name of th…

b3ef284

…e subclass, not the superclass, even if you don't redecorate with another @attr.s

hynek added a commit that referenced this pull request Jul 22, 2015

Merge pull request #20 from cyli/subclass-repr

c6e2f1f

Fix the repr to work for non-redecorated subclass.

hynek merged commit c6e2f1f into python-attrs:master Jul 22, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the repr to work for non-redecorated subclass. #20

Fix the repr to work for non-redecorated subclass. #20

cyli commented Jul 21, 2015

codecov-io commented Jul 21, 2015

hynek commented Jul 22, 2015

Fix the repr to work for non-redecorated subclass. #20

Fix the repr to work for non-redecorated subclass. #20

Conversation

cyli commented Jul 21, 2015

codecov-io commented Jul 21, 2015

Current coverage is 100.0%

hynek commented Jul 22, 2015

Current coverage is `100.0%`