Merging pytest-capturelog into core

[The-Compiler]

We talked a bit about this at EuroPython, but I think it's good to have a ticket to track this.

What about merging pytest-capturelog into the core?

• It's a widely used functionality/plugin
• The author seems non-responsive and the project dead (see issues)
• @bubenkoff created an issue proposing to move it to pytest-dev in March, with no response
• There's a fork, pytest-catchlog, where the author is more responsive (sometimes...), but I don't think it's widely known/used.
• Having two options (-catchlog vs. -capturelog) with no clear list of differences is confusing for someone new to pytest.

Doing another pytest-somethinglog plugin under pytest-dev would just increase confusion even more - and since it's definitely a feature which is widely used, I'd propose just merging it into pytest (after bringing the code up to current standards, like using fixtures instead of funcargs and hookwrapper instead of __multicall__) and blacklisting -catchlog and -capturelog.

Alternative possibilities:

• I'll just contribute to pytest-catchlog and use that, and other people probably will continue to use capturelog
• We move pytest-capturelog under pytest-dev if @eisensheng agrees, so it's at least the more "official"/endorsed one.

What do you think?

[eisensheng]

What do you think?

Absolutely fine with me. Like I stated at several occasions I forked the original repository only because the original author seems to have disappeared and I required some bug fixes and had some feature requests to assert certain log statements.

[RonnyPfannschmidt]

i'd like to discuss the general captureing mechanisms before the capturelog merge - i have some ideas i need to discuss with holger

[auvipy]

+1 make it offfishal

[nicoddemus]

There was a thread discussing this in the mailing list, and it was decided to leave pytest-catchlog as a third-party plugin.