Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove preinit, its no longer needed #2636

Merged

Conversation

RonnyPfannschmidt
Copy link
Member

by removing preinit we remove loading the initial plugin list

this is no longer needed, since we no longer use pytest-namespace for pytest itself

the followup for this one is to deprecate the pytest-namespace hook alltogether

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features July 31, 2017 09:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 91.81% when pulling 34909f2 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 91.81% when pulling e90f876 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 91.808% when pulling e90f876 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

IMHO we need a small adjustment to the changelog and this is good to go!

@@ -0,0 +1 @@
- remove plugin preinit, we no longer need to do that because the namespace is initialized in the module now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to make this more user oriented, the way it is now I doubt the general user will understand it. How about:

Remove internal ``_preloadplugins()`` function. This removal is part of the ``pytest_namespace()`` hook deprecation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 91.808% when pulling dcaeef7 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 6e75472 into pytest-dev:features Aug 1, 2017
@RonnyPfannschmidt RonnyPfannschmidt deleted the remove-preinit branch November 13, 2017 10:06
@uSpike uSpike mentioned this pull request Nov 27, 2017
nicoddemus added a commit that referenced this pull request Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants