Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unserialize reprlocals to a ReprLocal instance #178

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Unserialize reprlocals to a ReprLocal instance #178

merged 1 commit into from
Jul 5, 2017

Conversation

timyhou
Copy link

@timyhou timyhou commented Jun 30, 2017

This is in reference to issue #176 and a continuation of PR #164 and #171

I had to instantiate ReprLocals. Added more asserts around comparing the initial report against the result after being serialized, unserialized.

I think in the initial review @RonnyPfannschmidt mentioned this kind of functionality should me moved in pytest-core. I wholeheartedly agree, since I am terrible at handling it myself. Please be critical of my method since I obviously keep overlooking aspects and introducing new issues.

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • Add a news file into the changelog folder, following these guidelines:

    • Name it $issue_id.$type for example 588.bug

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Jun 30, 2017

@timyhou dont feel down, you are introducing a entirely new feature level and its not easy to do so

your quick handling of the problem as they come up is exemplary and noteworthy 👍
after all the problem is something that has no tests to show for to begin with since it wasn't even halfway possible before

when you explore new horizons there are minor setbacks to be expected, and you navigates those well

@timyhou
Copy link
Author

timyhou commented Jun 30, 2017

Thanks for the words of encouragement!

The test failure is TestDistribution.test_keyboard_interrupt_dist _ which also occurred during #170 so I will assume the judgement is the same?

not trivial to fix but also not critical

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that failure is unrelated, things look good
i think its fine to merge after @nicoddemus had a look

@nicoddemus nicoddemus merged commit 5d757f9 into pytest-dev:master Jul 5, 2017
@nicoddemus
Copy link
Member

Thanks @timyhou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants