Unserialize reprlocals to a ReprLocal instance #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to issue #176 and a continuation of PR #164 and #171
I had to instantiate ReprLocals. Added more asserts around comparing the initial report against the result after being serialized, unserialized.
I think in the initial review @RonnyPfannschmidt mentioned this kind of functionality should me moved in pytest-core. I wholeheartedly agree, since I am terrible at handling it myself. Please be critical of my method since I obviously keep overlooking aspects and introducing new issues.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
Make sure to include reasonable tests for your change if necessary
Add a news file into the
changelog
folder, following these guidelines:Name it
$issue_id.$type
for example588.bug
If you don't have an issue_id change it to the PR id after creating it
Ensure type is one of
removal
,feature
,bugfix
,vendor
,doc
ortrivial
Make sure to use full sentences with correct case and punctuation, for example: